View Single Post
  #287 (permalink)  
Old 28th March 2008, 02:52
seedat0r seedat0r is offline
 
Join Date: Mar 2008
Posts: 30
seedat0r is on a distinguished road
Groans: 0
Groaned at 0 Times in 0 Posts
Thanks: 2
Thanked 21 Times in 8 Posts
!k-0t1c!, you should remove the ASCII dumping, its broken. The signatures in it get broken and like 100 bytes are added (for cod2) compared to the bin without a reason - and yes, it looks the same in editor, but editor seems to drop bytes. If people use this it wont cause any violations.

What is ASCII dumping anyway? You just write the bytes and thats it. Oh and adding CRLF for newline also is a bit unneeded, and newlines can be caused by the sig bytes themselves as well. Besides, its not readable stuff anyway.

EDIT: Oh, would be nice if you could add support for files that contain LF format instead of CRLF as well. Evenbalance seems to mix it. For example, the bf2 pbpat.1 uses LF only. You could also make the parser independent of newlines altogether.

EDIT2: Tried the bf2 file with CRLF format. Get an "index out of range" error.

Last edited by seedat0r : 28th March 2008 at 03:08